src/services/search/Elastic.Documentation.Search/Common/RuleQueryMatchCriteriaTypeInfoResolver.cs (1)

24-30: ⚡ Quick win

Guard against caching JsonTypeInfo across JsonSerializerOptions in RuleQueryMatchCriteriaTypeInfoResolver

• System.Text.Json requires the returned JsonTypeInfo to match the same JsonSerializerOptions instance passed to GetTypeInfo; returning a JsonTypeInfo created for different options can throw (e.g., InvalidOperationException).
• In this repo, ElasticsearchClientJsonResolver.Default is only wired into DefaultSourceSerializer from ElasticsearchClientAccessor, which is registered as a singleton, so the current code path is unlikely to exercise multiple JsonSerializerOptions instances. If the resolver is ever reused with multiple clients/options, remove the memoization or cache per JsonSerializerOptions.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/services/search/Elastic.Documentation.Search/Common/RuleQueryMatchCriteriaTypeInfoResolver.cs`
around lines 24 - 30, The cached field _ruleQueryMatchCriteriaTypeInfo violates
System.Text.Json's requirement that a JsonTypeInfo must be tied to the
JsonSerializerOptions used to create it; update GetTypeInfo so it does not
return a single memoized JsonTypeInfo for different options—either remove the
_ruleQueryMatchCriteriaTypeInfo memoization and always call
CreateRuleQueryMatchCriteriaTypeInfo(options) for the RuleQueryMatchCriteriaType
case, or implement a cache keyed by the JsonSerializerOptions instance (e.g., a
Dictionary<JsonSerializerOptions, JsonTypeInfo>) so
CreateRuleQueryMatchCriteriaTypeInfo is invoked with the correct options; adjust
or remove the _ruleQueryMatchCriteriaTypeInfo field and ensure GetTypeInfo still
compares against RuleQueryMatchCriteriaType.